cli: improve usagemsgs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just a couple of changes to avoid tracebacks when someone just runs `atomfs mount` or `atomfs mount -h` to see what the usage should be. for both, use ArgsUsage to add the args info to the help output for mount, check #args and run findImage before the priv check so we get usage first for umount update the message to include the command Signed-off-by: Michael McCracken <[email protected]>
hallyn
approved these changes
Sep 26, 2024
|
LGTM - but let's wait till a pr fixing codecov is merged, then please rebase this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 16.52% 16.52%
=======================================
Files 6 6
Lines 932 932
=======================================
Hits 154 154
Misses 757 757
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a couple of changes to avoid tracebacks when someone just runs
atomfs mountoratomfs mount -hto see what the usage should be.for both, use ArgsUsage to add the args info to the help output
for mount, check #args and run findImage before the priv check so we get usage first
for umount update the message to include the command